Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbols not displaying in web app #11

Closed
pt-rick opened this issue Aug 18, 2023 · 6 comments
Closed

Symbols not displaying in web app #11

pt-rick opened this issue Aug 18, 2023 · 6 comments

Comments

@pt-rick
Copy link

pt-rick commented Aug 18, 2023

Was thrilled to find your package as there are multiple Material icons I found missing in the standard Flutter Icons. Thank you!

When I attempt to use Symbols in a web app, they appear as rectangles with an ‘x - likely standard for a missing IconData? You can see the Symbol icons below the regular Flutter Icons attached. Everything looks fine on my Android Flutter app BTW.

image

I know the live example of the web app shows the symbols so I'm sure that this is something simple but I don’t see any calls in the example that might rectify getting the symbols to show in my web app.

Thanks, Rick

@timmaffett
Copy link
Owner

timmaffett commented Aug 20, 2023 via email

@pt-rick
Copy link
Author

pt-rick commented Aug 21, 2023

Ah - perhaps that's the issue. I'm using Flutter 3.7.11 (Dart 2.19.6) stable since we have yet to move our application to null safety. I did try and rebuild the web app using --no-tree-shake-icons, but the symbol icons are still not showing in the web app. Our app isn't open source but the use of the icons is very simple - I have a map of strings to IconData and use the string as the key and pass the resulting IconData into a Flutter Icon. In the image I attached earlier, the icons that are displaying are Icons (e.g. Icons.tv) and the ones failing are Symbols (e.g. Symbols.tv_with_assistant). Just passing a symbol icon into Icon would be equivalent.

@timmaffett
Copy link
Owner

timmaffett commented Aug 21, 2023 via email

@pt-rick
Copy link
Author

pt-rick commented Aug 21, 2023

Correct - no Symbols are working in the web. They are fine on the Android, and, I'm assuming ,the iOS, side. I haven't tried iOS yet.

@pt-rick
Copy link
Author

pt-rick commented Sep 27, 2023

Quick update. I migrated our app to null safety and the symbols now work across our platforms.

@pt-rick pt-rick closed this as completed Sep 27, 2023
@timmaffett
Copy link
Owner

@pt-rick That's great news!

btw. I should be making a new release this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants