refactor: make tierNameList dependent on the state of tierDict #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## praatio_v6 #43 +/- ##
=============================================
Coverage ? 75.71%
=============================================
Files ? 21
Lines ? 2623
Branches ? 0
=============================================
Hits ? 1986
Misses ? 637
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
timmahrt
deleted the
39_prevent_inconsistent_state_with_tier_name_list
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses concerns raised in: #39
Before this PR, tierNameList and tierDict were independent. An unwary user could create a Tier with an inconsistent tierNameList and tierDict.
After this PR, tierNameList is derived from tierDict. Furthermore, tierNameList has been made read only and tierDict was made protected (_tierDict). _tierDict should be accessed and modified via the provided helper methods tg.addTier, tg.getTier, tg.removeTier, and tg.renameTier.