-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed a problem with possibly new espressif api #209
Comments
I'd heard murmurs about a breaking change to ESP-NOW, but when I updated my ESP32 boards in Arduino yesterday it still worked. Today I see it did not update to the newest 3.0 version. I'm updating now and I can see the changes from the documentation. Thanks a lot for submitting this! I'll get it patched up soon and tack you on as a co-contributor! |
Yes I have installed version 3.0.0 today. Thanks |
I also just purchased that same LoRa32 V2.1_1.6 yesterday (for the first time). There shouldn't be any issue! |
Co-Authored-By: Heinz Haeberle <281508+kheinz57@users.noreply.github.com> #209
Thanks again, @kheinz57! |
Well that was fun. For those of us using VSCode and Platform IO it seems that the PIO team has not adopted the new 3.0 version in the stable branch. You have to go to the development branch of PIO. I had to make some changes to platformio.ini to get the new development branch to work:
Now when I run the compile, in the output I see:
Using the stable version the same output was:
For more information see: |
Seems to be a political or monetary issue between Espressif and PlatformIO Teams. platformio/platform-espressif32#1225 (comment) For PIO users I'm going to paste my compile errors so that this can be, hopefully, found a bit quicker.
|
@aviateur17 If this continues, can we use directives to compile ESP-NOW differently when under ESP32 core v2.x? Or, alternatively to compile differently for PIO if needed? That's my best solution at the moment. Hopefully it's just Espressif dragging their feet. Definitely sounds like a pain. Did you get it working? |
Yeah, got it working so I don't think we need to take any action now. Hopefully Espressif and Platform IO get things figured out or many people will be disappointed. I just wanted to make a note for the others that are using PlatformIO on the steps they need to get it working. The issue is due to the change in Espressif API in their more up to date versions and PlatformIO not supporting those versions in stable branch yet. Hope they get it figured out. |
Yep, just read up on it and it sounds like a business disagreement. I didn't actually realize that Espressif supports their own PIO core (well, used to). I guess I assumed the PIO community adapted the Arduino core. |
I got some compile messages which I have fixed with this patch.
As I have no real board yet I can not proof the fix but the compiler at least succeeded.
The function signature for the callback has changed in its first parameter from mac_addr to esp_now_recv_info
(The parameter name should also be changed from mac to recv_info or so)
The text was updated successfully, but these errors were encountered: