Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mifare_ultralightc_authenticate(): Set errno when authentication fails. #20

Closed
GoogleCodeExporter opened this issue Mar 12, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

Currently, mifare_ultralightc_authenticate() returns -1 and does not touch 
errno when authentication fails. This is very strange and probably errorneous 
behavior and makes it difficult to do proper error handling.

I suggest to change libfreefare to set errno to EACCES (access denied) if 
authentication fails. Attached is a patch that implements this change.

Original issue reported on code.google.com by fuz...@gmail.com on 25 Feb 2014 at 12:33

Attachments:

@GoogleCodeExporter
Copy link
Author

Thank you.
This has been pushed but I leave the issue open as I will have probably to 
implement the same for the other cards.
I'll check once I can do some tests.

Original comment by yob...@gmail.com on 13 Mar 2014 at 1:21

@GoogleCodeExporter
Copy link
Author

Original comment by yob...@gmail.com on 13 Mar 2014 at 1:21

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

Fixed by commits 
184c5dcbdf50b5f5700ee5c7c2aa3fc70a5028b6 ULC
c72a55993b0c57f5a6e6b0544cefdc5463efca47 MFC
c4e657f8cdf8584996846e49ce108b392ac6c968 DF

Original comment by yob...@gmail.com on 14 Mar 2014 at 9:53

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant