Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make gas tariff optional #79

Merged
merged 1 commit into from
Apr 21, 2024
Merged

Make gas tariff optional #79

merged 1 commit into from
Apr 21, 2024

Conversation

mduffin95
Copy link
Contributor

Proposed Changes

Some properties are electricity only so deserialisation breaks when requesting plans.

Related Issues

Fixes #78

@timmo001
Copy link
Owner

Thanks for this. I've recently refactored these models so have updated your changes to the new setup

@timmo001 timmo001 self-requested a review April 21, 2024 10:58
@timmo001 timmo001 merged commit 28e164f into timmo001:master Apr 21, 2024
5 of 13 checks passed
@timmo001 timmo001 added the bugfix Inconsistencies or issues which will cause a problem for users or implementors. label Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmo001 timmo001 timmo001 approved these changes

Assignees
No one assigned
Labels
bugfix Inconsistencies or issues which will cause a problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does not support electricity only plans
2 participants
@mduffin95 @timmo001