[therock] added implementation for user trade history

knowm · Oct 27, 2016 · 906d1ea · 906d1ea
1 parent 90b6972
commit 906d1ea
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/xchange-therock/src/main/java/org/knowm/xchange/therock/TheRockAuthenticated.java b/xchange-therock/src/main/java/org/knowm/xchange/therock/TheRockAuthenticated.java
@@ -84,6 +84,7 @@ TheRockOrder showOrder(@PathParam("fund_id") TheRock.Pair currencyPair, @PathPar
   @Path("funds/{fund_id}/trades")
   TheRockUserTrades trades(@PathParam("fund_id") TheRock.Pair currencyPair, @HeaderParam(X_TRT_KEY) String publicKey,
       @HeaderParam(X_TRT_SIGN) TheRockDigest signer, @HeaderParam(X_TRT_NONCE) SynchronizedValueFactory<Long> nonceFactory
-      , @QueryParam("trade_id") Long sinceTradeId, @QueryParam("after") Date after, @QueryParam("before") Date before)
+      , @QueryParam("trade_id") Long sinceTradeId, @QueryParam("after") Date after, @QueryParam("before") Date before
+      , @QueryParam("per_page") int perPage)
       throws TheRockException, IOException;
 }
diff --git a/...-therock/src/main/java/org/knowm/xchange/therock/service/polling/TheRockTradeService.java b/...-therock/src/main/java/org/knowm/xchange/therock/service/polling/TheRockTradeService.java
@@ -79,7 +79,9 @@ public UserTrades getTradeHistory(TradeHistoryParams params) throws IOException
       Long sinceTradeId = null;        // get all trades starting from a specific trade_id
       if (params instanceof TradeHistoryParamsIdSpan) {
           TradeHistoryParamsIdSpan trId = (TradeHistoryParamsIdSpan) params;
-          sinceTradeId = Long.valueOf(trId.getStartId());
+          try {
+            sinceTradeId = Long.valueOf(trId.getStartId());
+        } catch (Throwable ignored) {}
       }
       Date after = null;
       Date before = null;

diff --git a/...erock/src/main/java/org/knowm/xchange/therock/service/polling/TheRockTradeServiceRaw.java b/...erock/src/main/java/org/knowm/xchange/therock/service/polling/TheRockTradeServiceRaw.java
@@ -76,7 +76,7 @@ public TheRockUserTrades getTheRockUserTrades(CurrencyPair currencyPair, Long si
         try {
 
             return theRockAuthenticated.trades(new TheRock.Pair(currencyPair), exchange.getExchangeSpecification().getApiKey(),
-                    signatureCreator, exchange.getNonceFactory(), sinceTradeId, after, before);
+                    signatureCreator, exchange.getNonceFactory(), sinceTradeId, after, before, 200);
         } catch (Throwable e) {
             throw new ExchangeException(e);
         }