Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

20 mBTC Bounty - Refactor xchange-mtgox polling V2 module #273

Closed
timmolter opened this issue Jan 24, 2014 · 6 comments
Closed

20 mBTC Bounty - Refactor xchange-mtgox polling V2 module #273

timmolter opened this issue Jan 24, 2014 · 6 comments

Comments

@timmolter
Copy link
Member

Rules for bounties and the explanation of the refactor can be found here: #270

Classes that need to be split:

MtGoxAccountService
MtGoxMarketDataService
MtGoxTradeService

Relevant example classes should also be updated to show both raw and generic polling functions
gnandiga pushed a commit to gnandiga/XChange that referenced this issue Feb 3, 2014
knowm#273: Refactored MtGoxAccountService
c14af59
@gnandiga
Copy link

gnandiga commented Feb 3, 2014

Tim,

I have refactored MtGoxAccountService. I think, I followed the instructions in #270. Can you take look at my commit and tell me if I am going in the right direction: gnandiga@c14af59

gnandiga pushed a commit to gnandiga/XChange that referenced this issue Feb 3, 2014
knowm#273: Refactored MtGoxMarketDataService
a92bc49
@timmolter
Copy link
Member Author

@gnandiga Looks really good!

gnandiga pushed a commit to gnandiga/XChange that referenced this issue Feb 3, 2014
knowm#273: Refactored MtGoxTradeService
8fe70de
gnandiga pushed a commit to gnandiga/XChange that referenced this issue Feb 3, 2014
knowm#273: Updated demo's to run both raw and generic services
f1bc505
gnandiga pushed a commit to gnandiga/XChange that referenced this issue Feb 3, 2014
knowm#273: Updated MtGoxMarketDataService as per @jamespedwards42 cod…
b30d13d 
…e review
gnandiga pushed a commit to gnandiga/XChange that referenced this issue Feb 4, 2014
knowm#273: Updated method name to camelCase
f1a306c
gnandiga pushed a commit to gnandiga/XChange that referenced this issue Feb 4, 2014
knowm#273: Updated MtGoxAccountService to do checks on arguments
a2acf41
timmolter added a commit that referenced this issue Feb 4, 2014
@timmolter
Merge pull request #287 from gnandiga/develop
7224542 
#273 Refactoring complete
gnandiga pushed a commit to gnandiga/XChange that referenced this issue Feb 4, 2014
knowm#273: Completed demo's, more refactoring in MtGoxMarketDataService
6db9605
timmolter added a commit that referenced this issue Feb 4, 2014
@timmolter
Merge pull request #290 from gnandiga/develop
9cb4ccb 
#273 Demo's Update complete
gnandiga pushed a commit to gnandiga/XChange that referenced this issue Feb 4, 2014
knowm#273: Fixed NPE in DepthDemo
26933ae
@gnandiga gnandiga mentioned this issue Feb 4, 2014
Merged
timmolter added a commit that referenced this issue Feb 4, 2014
@timmolter
Merge pull request #292 from gnandiga/develop
35da1ce 
#273: Fixed NPE in DepthDemo
@timmolter
Copy link
Member Author

Just putting the Bitcoin address here from pull request: #287

112LnfRzmA6AMU5i6SHPCGpjM3Ya5pBVLb

@timmolter
Copy link
Member Author

Bounty paid to 112LnfRzmA6AMU5i6SHPCGpjM3Ya5pBVLb. Thanks for your work! I added you as a contributor here as well: https://github.com/timmolter/XChange/wiki

@timmolter
Copy link
Member Author

@gnandiga Where did you find out about this bounty? I posted it in several places.

@gnandiga
Copy link

gnandiga commented Feb 4, 2014

I found it on coinality.com.

gnandiga pushed a commit to gnandiga/XChange that referenced this issue Feb 6, 2014
knowm#273: Added BitstampSuccessResponse deserailzer for appropriatly…
448f9ee 
… deserializing the response
alphafoobar pushed a commit to alphafoobar/XChange that referenced this issue Aug 6, 2019
@Flemingjp
Merge pull request knowm#273 from badgerwithagun/bitfinex-authenticated
85c1f7f 
[bitfinex] Added some methods of authenticated api (version 2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gnandiga @timmolter