Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message for CreateChromatinAssay min.cells argument #387

Closed
skilpinen opened this issue Jan 8, 2021 · 1 comment
Closed

Error message for CreateChromatinAssay min.cells argument #387

skilpinen opened this issue Jan 8, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@skilpinen
Copy link

Just noticed that setting min.cells so high that no features fulfilled the constraint leads to an error regarding dgCMatrix dimnames. See below. While logical why, don't know if you want to consider more informative error there. Took some testing to validate that this was the reason behind the error.

Error in dimnamesGets(x, value) :
invalid dimnames given for "dgCMatrix" object

@skilpinen skilpinen added the enhancement New feature or request label Jan 8, 2021
@timoast
Copy link
Collaborator

timoast commented Jan 30, 2021

Thanks, this is a good point and I've now added more informative error messages to the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants