-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature for excluding names #29
Conversation
I have also updated package dependencies as it prompted vulnerabilities |
@CalmarBen You don't need to, I don't even think that it will prevent these properties from renaming though (if it does then I'd fix it 😄). To prevent minifying these properties a type of that object should be publicly accessible or marked as "public" via jsdoc. Do you have c complete example of this issue in your project or is it possible to create a repro? I believe it should be fixed in different even without modifying the code of the tool. This option might be useful for loose mode (see #14), we don't have it yet. |
Thanks for looking at my PR +1:
used like this, for example: |
Have you tried to replace |
I'd say this is a bug tbh 😂 I'll fix this later. I think that this is a bug because this tool relies on the type information rather than the syntax so whatever syntax you use it should work the same IMO. |
You are right, this is working. This is nice tip, I think I would never find out to solve it this way. Thanks a lot @timocov |
I think I can remove my PR ... |
publicJSDocTag does not meet all use case I have.
For example I use some code like this:
this.Add('rect', { x:0, y:0, width: rectWidth, height: rectHeight, class: 'rec_class'} );
I don't want to quote every item like this (this is less readable)
this.Add('rect', { 'x':0, 'y':0, 'width': rectWidth, 'height': rectHeight, 'class': 'rec_class'} );
In this usecase I think it is more flexible to use an exlusion from a list, like this in webpack.config.js: