Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a detail page for a selected item #7

Closed
timofeysie opened this issue Dec 4, 2019 · 3 comments
Closed

create a detail page for a selected item #7

timofeysie opened this issue Dec 4, 2019 · 3 comments

Comments

@timofeysie
Copy link
Owner

No description provided.

@timofeysie
Copy link
Owner Author

Create a details page to show the details of an item selected.

An item can be used to get a detail page from Wikipedia.
Wikidata will also hold a list of languages available for each item.  This property can be used to get translated pages.

Detail pages also contain preamble icons with warnings which need to be captures and shown as collapsable icons under the description.
https://github.com/timofeysie/strumosa-pipe#the-items-api

Add a directory in the features/category-item-details so it will look like this:
├── items/
├── item-details/
├── categories/
├── category-item-details-routing.module.ts
└── category-item-details.module.ts

The directory will contain these features, like the categories directoy:
├── item-details.component.ts/.html/.scss/.spec
├── components/
├── containerss/
├── item-details.endpoint.ts
├── item-details/store.state.ts
└── item-details.store.ts

@timofeysie
Copy link
Owner Author

Done:

  • Scaffolded the item-details feature module.
  • Created a service to use the wikidata q-code to get a list of link entities.
  • Also replaced the quote service default with a build in demo of a item detail.
  • Used the detail to show the label and a link to the Wikipedia page.

To do:

  • Move the service operation into the item-detail.endpoint file.
  • Create a state for statistics on detail view to track activity.
  • Get a list of available languages and create a select in the header.
  • Replace the hard coded language settings with an item from the list based on the current language saved option.
  • Parse the Wikipedia page for sections and display the description.
  • Save the description in the state and use part of it as a slide in element in the category-items

Item details was a blocker, so all these things can happen now. Probably create some new issues to handle most of these.

@timofeysie
Copy link
Owner Author

More todo:

  • Add interfaces for details.
  • Fix the unit tests.
  • Try a red-green-refactor session to start to build up unit test code coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant