Pendulum 2.0.2 compatibility #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormatting scheme by default
- Previously, we depended on pendulum throwing a ParserError when parsing an interval where the end was a duration expression - Pendulum now returns successfully parses durations and returns a Duration (not a DateTime), causing Maya's parser to fault because it assumes that pendulum always sends back a DateTime - Now we catch the TypeError maya itself throws in this case (indicating that the duration hasn't been successfully parsed into a datetime object) and try to parse it as a duration instead
- Previously, maya depended upon pendulum falling back to datetime parsing for cases it couldn't handle; however, pendulum now does strict parsing by default, and will throw instead of delegating to stdlib parsing - Provide a strict keyword arg on maya's parse method that defaults to False so that we by default can get the old delegating behaviour from pendulum when parsing
timofurrer
requested review from
kennethreitz and
timofurrer
and removed request for
kennethreitz
|
Thanks for this first step 🎉 Do you know of any semantic changes in pendulum 2.0 which would break mayas API? |
|
I'm sorry, I don't -- my only knowledge of pendulum is through use of maya, and my use of maya is quite casual; the fixes to get maya at least testing clean with pendulum 2.0.2 seemed pretty straightforward, but I didn't do more investigation than just that. |
|
The list of 2.0.0 changes is here: https://github.com/sdispater/pendulum/releases/tag/2.0.0 The 2.0.2 changes are just bug fixes. |
|
any updates on this one? |
luisdavim
approved these changes
Nov 26, 2018
|
Unfortunately, not from my side. I'll find some time tomorrow to have a look at this! |
Merged
|
I'm closing this PR in favor of #166 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does the minimal work required to get maya working with pendulum 2.0.2, and run the test suite clean on py2.7 and py3.6.
Possible area for improvement:
Addresses issue #160