Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python versions in travis #70

Merged
merged 2 commits into from Jan 29, 2020

Conversation

jonte
Copy link
Contributor

@jonte jonte commented Jan 19, 2020

This includes an update of flake8 to 3.7.9, since 3.3.0 does not support python 3.8.

This PR should build OK if #69 is merged.

flake8 version 3.3.0 does not support python 3.8, and will yield the
following error:

    ... SNIP ...
      File
    "/home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/pyflakes/checker.py",
    line 862, in handleNode

        handler = self.getNodeHandler(node.__class__)

      File
    "/home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/pyflakes/checker.py",
    line 696, in getNodeHandler

        self._nodeHandlers[node_class] = handler = getattr(self, nodeType)

    AttributeError: 'FlakesChecker' object has no attribute 'CONSTANT'
Python 3.7 has been released, so replace 3.7-dev with 3.7. 3.8 is
stable.
@codecov-io
Copy link

codecov-io commented Jan 19, 2020

Codecov Report

Merging #70 into master will decrease coverage by 48.9%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #70       +/-   ##
===========================================
- Coverage   95.91%   47.01%   -48.91%     
===========================================
  Files           6        6               
  Lines         245      502      +257     
===========================================
+ Hits          235      236        +1     
- Misses         10      266      +256
Impacted Files Coverage Δ
w1thermsensor/cli.py 35.21% <0%> (-64.79%) ⬇️
w1thermsensor/core.py 55.02% <0%> (-40.44%) ⬇️
w1thermsensor/errors.py 67.74% <0%> (-32.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 227a9df...326594c. Read the comment docs.

@timofurrer timofurrer merged commit 54b3e68 into timofurrer:master Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants