Fix greeting and triage #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I messed this up when factoring out the post_comment function. Forgot to await it. There should be some linter that detects un-awaited awaitables statically.
timokau
added a commit
to nix-community/infra
that referenced
this pull request
Jul 8, 2020
- Fix greeting failing to be posted - Fix / wait out race condition. Both in timokau/marvin-mk2#62
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The greeting is broken (NixOS/nixpkgs#92705 (comment)) due to the missing await, the triage has a race condition where sometimes the newly labeled PRs don't turn up in the search (NixOS/nixpkgs#90245). Let's see if 5 seconds is sufficient.