Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pagination call #364

Open
mysiki opened this issue Oct 23, 2019 · 3 comments · May be fixed by #378
Open

Improve pagination call #364

mysiki opened this issue Oct 23, 2019 · 3 comments · May be fixed by #378

Comments

@mysiki
Copy link

mysiki commented Oct 23, 2019

Hey, can you improve pagination management ? I use this api for manage many users and many groups, but each call consume "+1" api call ... For each call, you iterate until result are null. So last call is unless, it's just for test than you don't have other page.

It's possible to use 2 methods :
1 - Use the header return, gitlab give some paging information on header, and the next page if exist .. So you can check this header value pour stop iteration .
2 - You have variable "item per page", so just count call return entry Vs item per page. If return count are < item per page, you don't need to call the next page

Hope you can take time on it. :)

@mysiki
Copy link
Author

mysiki commented Oct 23, 2019

@timols
Copy link
Owner

timols commented Oct 26, 2019

Hi @mysiki, I'd be happy to review/merge a PR but unfortunately don't have the bandwidth at the moment to contribute this change myself

@mysiki
Copy link
Author

mysiki commented Oct 27, 2019

I will be very happy to do this, but i didn't have thé skill for doing that...i will try,maybe

@morganseznec morganseznec linked a pull request Jul 16, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants