New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cron validation for Jenkins>=1.558 #59
Conversation
Would you mind updating the Jenkins version in |
Sure, I can. However, I am not familiar with Jenkins plugins development but since this change is supposedly backwards compatible, is there really a need to build against a very recent |
hope this can land soon. it prevents saving some configs unless the cron part is disabled (emptied out) |
Huge +1. |
+1! |
+1 |
1 similar comment
+1 |
+1, I assume this will Close #56 that I opened. |
+1 |
1 similar comment
+1 |
I've merged in #62 which has the same changes but includes |
@timols great! I'd still like to understand the rationale behind the bump though (and the reason why 1.532 was chosen) so I can do it properly next time. |
See https://issues.jenkins-ci.org/browse/JENKINS-22550 for details about the exact same issue for the github plugin. Fix shamelessly copied from jenkinsci/ghprb-plugin#28