Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cron validation for Jenkins>=1.558 #59

Closed
wants to merge 1 commit into from

Conversation

bjaglin
Copy link

@bjaglin bjaglin commented Apr 24, 2014

See https://issues.jenkins-ci.org/browse/JENKINS-22550 for details about the exact same issue for the github plugin. Fix shamelessly copied from jenkinsci/ghprb-plugin#28

@timols
Copy link
Owner

timols commented Apr 29, 2014

Would you mind updating the Jenkins version in pom.xml?

@bjaglin
Copy link
Author

bjaglin commented Apr 29, 2014

Sure, I can. However, I am not familiar with Jenkins plugins development but since this change is supposedly backwards compatible, is there really a need to build against a very recent org.jenkins-ci.plugins:plugins parent?

@eddiemonge
Copy link

hope this can land soon. it prevents saving some configs unless the cron part is disabled (emptied out)

@theneva
Copy link

theneva commented May 1, 2014

Huge +1.

@madsroskar
Copy link

+1!

@acr92
Copy link

acr92 commented May 1, 2014

+1

1 similar comment
@Hellslicer
Copy link

+1

@arjes
Copy link

arjes commented May 6, 2014

+1, I assume this will Close #56 that I opened.

@garbagetown
Copy link

+1

1 similar comment
@muuki88
Copy link

muuki88 commented May 13, 2014

+1

@timols
Copy link
Owner

timols commented May 13, 2014

I've merged in #62 which has the same changes but includes pom.xml changes.

@bjaglin
Copy link
Author

bjaglin commented May 13, 2014

@timols great! I'd still like to understand the rationale behind the bump though (and the reason why 1.532 was chosen) so I can do it properly next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet