Find package for vsg projects #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added extra --sd maxShadowDistance control for shadow maps to worldviewer command line.
…_package first then if that fails resort to FetchContext.
|
The FIND_PACKAGE_ARGS forms in FetchContent_Declare are supposed to take care of this, but that's a new feature of CMake 3.24. I know that I just accepted a PR to support CMake 3.22; at some point I want to move on. As I understand it, the issue is that Ubuntu 22 officially only supports CMake 3.22; is it onerous to use a package manager, e.g., snap, to install a newer version of CMake? |
|
I didn't know that the FIND_PACKAGE_ARGS was able to trigger a find_package instead of pulling down the repo, thanks for the tip. I just pull in cmake from apt-get so the debian style repo rather than snap. Ubuntu 22.04 is still the last long term support version of Ubuntu so will be the one many Linux devs will be on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.