Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make field writing order consistent between CODE_SIZE and SPEED #577

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jcready
Copy link
Contributor

@jcready jcready commented Aug 10, 2023

Fixes #453

Binary serialization is explicitly not expected to be consistent between different code generators and languages, but we should at least be self-consistent within protobuf-ts.

// We list fields out of order, to ensure that we're using field number and not
// field index to determine serialization order.
message TestFieldOrderings {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make field writing order consistent between CODE_SIZE and SPEED
1 participant