Fix issue #1038: Adding support for combining sort within sections wi…

…th length_sort
PyCQA · Feb 18, 2020 · e99f820 · e99f820
1 parent b9e9258
commit e99f820
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/isort/output.py b/isort/output.py
@@ -117,6 +117,7 @@ def sorted_imports(
                     order_by_type=config.order_by_type,
                     force_to_top=config.force_to_top,
                     lexicographical=config.lexicographical,
+                    length_sort=config.length_sort,
                 ),
             )
 

diff --git a/isort/sorting.py b/isort/sorting.py
@@ -41,7 +41,11 @@ def module_key(
 
 
 def section_key(
-    line: str, order_by_type: bool, force_to_top: List[str], lexicographical: bool = False
+    line: str,
+    order_by_type: bool,
+    force_to_top: List[str],
+    lexicographical: bool = False,
+    length_sort: bool = False,
 ) -> str:
     section = "B"
 
@@ -54,7 +58,8 @@ def section_key(
         section = "A"
     if not order_by_type:
         line = line.lower()
-    return f"{section}{line}"
+
+    return f"{section}{len(line) if length_sort else ''}{line}"
 
 
 def naturally(to_sort: Iterable[str], key: Optional[Callable[[str], Any]] = None) -> List[str]: