isort ordering issue on Travis CI

[cas--]

We have encountered a very strange issue with isort where by it randomly decides to switch these two imports around but only when run in a virtualenv on Travis, we cannot replicate on local machines, it passes cleanly each and every time.

This is the diff from the Travis run, with an extract below: https://travis-ci.org/deluge-torrent/deluge/jobs/36309771

-from deluge.ui.client import Client, client
+from deluge.ui.client import client, Client

[cas--]

I did a little debugging and think it's related to _module_key() setting the key to lower so that when it is passed to natsorted it will be based on the (random) order the modules were added to from_modules list.

It appears that the workaround for now is to use order-by-type.

[timothycrosley]

Hi @cas--,

Thanks for reporting this issue, I plan on making order_by_type the default behavior in the next release which should fix this issue.

Thanks!

~Timothy Crosley

[timothycrosley]

A new version (3.9.1) has been released that fixes this issue.

Thanks again for reporting!

~Timothy