Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not-to-merge PR to check travis #4677

Closed
wants to merge 18 commits into from
Closed

Not-to-merge PR to check travis #4677

wants to merge 18 commits into from

Conversation

apb7
Copy link
Contributor

@apb7 apb7 commented Feb 11, 2018

This PR checks the Travis problem. Please do not merge.
Probable cause: Travis environment and local environment problem.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes.
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR follows the style guide.
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue.

@apb7
Copy link
Contributor Author

apb7 commented Feb 11, 2018

Hello @seanlip! I've canceled the currently running jobs since all of them were failing. Also, we need to run this first. Sorry for the inconvenience!

@apb7
Copy link
Contributor Author

apb7 commented Feb 11, 2018

@seanlip: As a hotfix, we can auto fix the jobs.py file while running on Travis. Should we do this? I'm not sure though.

@apb7
Copy link
Contributor Author

apb7 commented Feb 11, 2018

@seanlip: I've tried a number of things here but they are not working. All lint checks are passing locally and failing here on Travis. What else can we try here? Shall we go with the hotfix for this file? Please suggest.
Thanks!

@apb7
Copy link
Contributor Author

apb7 commented Feb 11, 2018

Okay, so I found a number of regression issues with isort on Travis (Issue 185, 457 and 541).
I'm looking into these at present.

@apb7
Copy link
Contributor Author

apb7 commented Feb 11, 2018

The problem seems (at this moment) to be the way dependencies are installed locally and the way they are installed in Travis. I wonder why this issue never popped up before.

@akumar1503
Copy link
Contributor

@apb7 i'm not fully aware what's going on. This seems to be blocking PR's badly. could you please tell if it happen suddenly or after merging some PR and what the actual problem is.

@apb7
Copy link
Contributor Author

apb7 commented Feb 11, 2018

@GanitGenius: Please go through this issue thread once. Also, this is the first time we're facing this issue since we setup isort. The problem lies in the Travis environment (stated in the thread).
Thanks!

@apb7
Copy link
Contributor Author

apb7 commented Feb 11, 2018

@seanlip: isort has been disabled to fix Travis. Closing this PR for now.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants