Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Might create blank line at start of file with comments #889

Closed
blueyed opened this issue Mar 7, 2019 · 2 comments
Closed

Might create blank line at start of file with comments #889

blueyed opened this issue Mar 7, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@blueyed
Copy link
Contributor

blueyed commented Mar 7, 2019

Running isort --diff with the following will add a blank line at the start:

# comment
import os
# comment2
import sys
@@ -1,4 +1,5 @@
+
+import os
 # comment
-import os
 # comment2
 import sys

The result then looks like this:

import os
# comment
# comment2
import sys
@timothycrosley
Copy link
Member

Thank you for reporting this!
Should be fixed in the latest release (4.3.13) of isort.

Thanks!

~Timothy

@timothycrosley timothycrosley added the bug Something isn't working label Mar 8, 2019
@blueyed
Copy link
Contributor Author

blueyed commented Mar 8, 2019

Awesome, thanks! Confirmed to be fixed with 855806f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants