all DNS records got deleted when IPv4 not detected

[dechunwang]

Describe the bug
Hi there, I had facing a problem where DDNS accidentally (randomly ) deleted all my DNS records on my site.
This happened three times on three different machines that installs ddns scripts.
I set up the config as in Doc:

{
  "cloudflare": [
    {
      "authentication": {
          "api_token": "xxx" 
      },
      "zone_id": "xxx",
      "subdomains": [
        "arm"
      ],
      "proxied": false
    }
  ],
  "a": true,
  "aaaa": false
}

To Reproduce
Crontab calling start-sync.sh every 4 mins
Expected behavior
should only update subdomain's ip address

Screenshots
the log output from the script:

it clear shows when IPv4 not detected, the program deleted all sub-domain dns record of my site.

here is the log in clouldflare:

Desktop (please complete the following information):

• OS: [Ubuntu 20.04]

Smartphone (please complete the following information):
N/A

Additional context
N/A

[JCAguilera]

Same happened to me today. Have you found any workarounds or fixes?

[mrtungdev]

Same :(

[anthonydiiorio]

Same. Was able to restore records from the audit log thankfully.

[kikkia]

I forked the repo and packaged a proposed pr to fix this. Until the pr is merged feel free to use this docker image registry.gitlab.com/kikkia/cloudflare-ddns its all open source if you want to verify what was changed.
https://gitlab.com/kikkia/cloudflare-ddns

[debMan]

Shit, same issue today

🧩 IPv4 not detected
🗑️ Deleted stale record 3f769304159294fa916c0950f45fb34f
🗑️ Deleted stale record 5c8c82a396502f7005671553baf5c981
🗑️ Deleted stale record 07847081a8b7acb596dd44970a50c454
🗑️ Deleted stale record 2041129286049685224070bd98e8c232
🗑️ Deleted stale record 6afee39b8b12bf8657e6e9eefa1f10cb
🗑️ Deleted stale record c96d0c8f99f263d86c9f3c148784786b

[osholt]

Has happened to me too, three times now! I thought I was going mad!

[debMan]

A quick fix:

Consider deleting the lines 46 and 57:

cloudflare-ddns/cloudflare-ddns.py

Line 46 in 458559d

deleteEntries("A")

cloudflare-ddns/cloudflare-ddns.py

Line 57 in 458559d

deleteEntries("AAAA")

    if ipv4_enabled:
        try:
            a = requests.get("https://1.1.1.1/cdn-cgi/trace").text.split("\n")
            a.pop()
            a = dict(s.split("=") for s in a)["ip"]
        except Exception:
            global shown_ipv4_warning
            if not shown_ipv4_warning:
                shown_ipv4_warning = True
                print("🧩 IPv4 not detected")
-            deleteEntries("A")
    if ipv6_enabled:
        try:
            aaaa = requests.get("https://[2606:4700:4700::1111]/cdn-cgi/trace").text.split("\n")
            aaaa.pop()
            aaaa = dict(s.split("=") for s in aaaa)["ip"]
        except Exception:
            global shown_ipv6_warning
            if not shown_ipv6_warning:
                shown_ipv6_warning = True
                print("🧩 IPv6 not detected")
-            deleteEntries("AAAA")

[asheroto]

Same here. Thankfully my monitor kicked in and alerted me - it deletes the A record for my root domain, not my subdomain!

Audit log of Cloudflare shows it was the API

[asheroto]

registry.gitlab.com/kikkia/cloudflare-ddns

Thank you, using this for now :-)

[mendhak]

Just got hit by this, I lost my root domain records. 😢

cloudflare-ddns    | 2021-10-29T01:22:03.247134081Z 🧩 IPv4 not detected
cloudflare-ddns    | 2021-10-29T01:22:08.121012339Z 🗑️ Deleted stale record 527a13178ebe61eec4e8xxxxxxx
cloudflare-ddns    | 2021-10-29T01:22:09.237220819Z 🗑️ Deleted stale record 367cf05cd8f9e3323b2f13xxxxxx
cloudflare-ddns    | 2021-10-29T01:22:10.362698135Z 🗑️ Deleted stale record fc9a275ab1fe17f38d8abaxxxxxx
cloudflare-ddns    | 2021-10-29T01:22:11.983824424Z 🗑️ Deleted stale record a88c0318557cb36ab81xxxxxx
cloudflare-ddns    | 2021-10-29T01:22:16.897925571Z 🗑️ Deleted stale record 1ca9750837f94a18131xxxxxx

@timothymiller this can be pretty dangerous, would appreciate some attention on this 🙏

[mendhak]

Any ideas where I can see what was deleted and restore it? I don't see any audit logs option in my Cloudflare DNS dashboard. Am I SoL?

[anthonydiiorio]

Any ideas where I can see what was deleted and restore it? I don't see any audit logs option in my Cloudflare DNS dashboard. Am I SoL?

https://dash.cloudflare.com/ click Audit Log in the navigation

[mendhak]

Ah it's at the top level, I wasn't seeing it in my panic-vision. Thank you so much @anthonydiiorio

[aaron2198]

Same thing happened to me as well, deleted all a records.

[timothymiller]

This has been fixed in PR #57