Config option for purge/delete of "stale" records #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Similar to #52 |
Repository owner
deleted a comment from
kikkia
Sep 16, 2021
Repository owner
deleted a comment from
ForsakenHarmony
Sep 16, 2021
|
Approved ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a config setting to control whether "stale" records are purged/deleted or not. Checks were put in place both in commitRecord(ip) to control whether duplicates are deleted (unsure how that case arises, but wanted to provide the option to not delete if someone didn't want to) as well as deleteEntries(type), which was pulling any A or AAAA record not listed in config.json file. People may be manually creating other A or AAAA records for purposes other than DDNS, and removing them automatically when trying to update DDNS records seems like an unintended action. For that reason, the config option is listed as "purgeUnknownRecords" as it will purge anything not listed in the config.json file. However, listing other A or AAAA records in the config.json will have them updated with the local IP to satisfy a DDNS update, so be careful listing anything you wouldn't want to change.
This pull request is intended to fix #47