-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent syntax for exporting functions #45
Comments
@Sequoia thanks for the feedback! I think this is valid, I'd accept a PR for the first style if you wanted to submit it 👍 |
Will do this week, thanks for quick follow up! |
Waiting for #43 to land or get rejected to do this one. (In that PR, I rename all the files in question in this issue). |
@Sequoia done |
Sequoia
added a commit
to Sequoia/functional-javascript-workshop
that referenced
this issue
Mar 28, 2014
also problem.md markdown cleanup closes timoxley#45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some do this:
Some do this:
Some do this:
There's not a functional issue here, and maybe these are intentionally written to expose the learner to multiple syntaxes for CommonJS exports, but I think this could trip up & confuse a beginner: "Why are there three ways to do this? Which one's better?" etc..
In my opinion either:
a) an explanation of modules/exports & their syntax should be included early on (probably via a lesson) or
b) these should all be standardized to one syntax, so the learner can focus on the lesson at hand and not "why is this boilerplate different from the last lesson"
I'm happy to fix these up and create a PR if such a change is welcome - just let me know. 👍
The text was updated successfully, but these errors were encountered: