Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spawn-sync dep #5

Closed
wesleytodd opened this issue Feb 4, 2016 · 3 comments
Closed

Remove spawn-sync dep #5

wesleytodd opened this issue Feb 4, 2016 · 3 comments

Comments

@wesleytodd
Copy link
Contributor

Is it possible to remove that dep in favor of using the built in one?

I understand backwards compat issues, BUT let me tell you my story:

I am using the linter happiness (a fork of standard). I added it to the package.json's of my company modules, about 100 of them. We are also using linklocal for development and a recursive link via bulk. Turns out that the npm install in all these directories takes like an hour. Here is the dependency tree that is leading here:

node_modules/happiness/node_modules/happiness-format/node_modules/esformatter/node_modules/npm-run/node_modules/spawn-sync

spawn-sync is a c extension, so gets compiled for every npm install that is run. I didnt spend the time to figure out how many times it is run, but I started it at like 9am and now it is 12 and it is still running :)

I had some time, so figured I would open an issue here.....

@timoxley
Copy link
Owner

I think this is a good call. Please submit a PR! 💃

@wesleytodd
Copy link
Contributor Author

Will do!! Probably on Monday :)

@wesleytodd
Copy link
Contributor Author

Closed in #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants