-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add --exact config for --save[-dev|-optional].
- Loading branch information
Showing
5 changed files
with
96 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,91 @@ | ||
var common = require('../common-tap.js') | ||
var test = require('tap').test | ||
var npm = require('../../') | ||
var osenv = require('osenv') | ||
var path = require('path') | ||
var fs = require('fs') | ||
var rimraf = require('rimraf') | ||
var mkdirp = require('mkdirp') | ||
var pkg = path.join(__dirname, 'install-save-exact') | ||
var mr = require("npm-registry-mock") | ||
|
||
test("setup", function (t) { | ||
mkdirp.sync(pkg) | ||
mkdirp.sync(path.resolve(pkg, 'node_modules')) | ||
process.chdir(pkg) | ||
t.end() | ||
}) | ||
|
||
test('"npm install --save --exact should install local pkg', function(t) { | ||
resetPackageJSON(pkg) | ||
mr(common.port, function (s) { | ||
npm.load({ | ||
cache: pkg + "/cache", | ||
loglevel: 'silent', | ||
registry: common.registry }, function(err) { | ||
t.ifError(err) | ||
npm.config.set('save', true) | ||
npm.config.set('exact', true) | ||
npm.commands.install(['underscore@1.3.1'], function(err) { | ||
t.ifError(err) | ||
var p = path.resolve(pkg, 'node_modules/underscore/package.json') | ||
t.ok(JSON.parse(fs.readFileSync(p))) | ||
var pkgJson = JSON.parse(fs.readFileSync(pkg + '/package.json', 'utf8')) | ||
t.deepEqual(pkgJson.dependencies, { | ||
'underscore': '1.3.1' | ||
}, 'Underscore dependency should specify exactly 1.3.1') | ||
npm.config.set('save', undefined) | ||
npm.config.set('exact', undefined) | ||
s.close() | ||
t.end() | ||
}) | ||
}) | ||
}) | ||
}) | ||
|
||
test('"npm install --save-dev --exact should install local pkg', function(t) { | ||
resetPackageJSON(pkg) | ||
|
||
mr(common.port, function (s) { | ||
npm.load({ | ||
cache: pkg + "/cache", | ||
loglevel: 'silent', | ||
registry: common.registry }, function(err) { | ||
t.ifError(err) | ||
npm.config.set('save-dev', true) | ||
npm.config.set('exact', true) | ||
npm.commands.install(['underscore@1.3.1'], function(err) { | ||
t.ifError(err) | ||
var p = path.resolve(pkg, 'node_modules/underscore/package.json') | ||
t.ok(JSON.parse(fs.readFileSync(p))) | ||
var pkgJson = JSON.parse(fs.readFileSync(pkg + '/package.json', 'utf8')) | ||
console.log(pkgJson) | ||
t.deepEqual(pkgJson.devDependencies, { | ||
'underscore': '1.3.1' | ||
}, 'underscore devDependency should specify exactly 1.3.1') | ||
s.close() | ||
npm.config.set('save-dev', undefined) | ||
npm.config.set('exact', undefined) | ||
t.end() | ||
}) | ||
}) | ||
}) | ||
}) | ||
|
||
test('cleanup', function(t) { | ||
process.chdir(__dirname) | ||
rimraf.sync(path.resolve(pkg, 'node_modules')) | ||
rimraf.sync(path.resolve(pkg, 'cache')) | ||
resetPackageJSON(pkg) | ||
t.end() | ||
}) | ||
|
||
function resetPackageJSON(pkg) { | ||
var pkgJson = JSON.parse(fs.readFileSync(pkg + '/package.json', 'utf8')) | ||
delete pkgJson.dependencies | ||
delete pkgJson.devDependencies | ||
delete pkgJson.optionalDependencies | ||
fs.writeFileSync(pkg + '/package.json', JSON.stringify(pkgJson)) | ||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
# just a test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
module.exports = true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{"name":"bla","description":"fixture","version":"0.0.1","main":"index.js","repository":"git://github.com/robertkowalski/bogusfixture"} |