add failing test case. #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const withoutNew = D('withoutNew') | ||
|
|
||
| t.equal(withNew.constructor, C, 'withNew has the correct constructor') | ||
| t.equal(withoutNew.constructor, C, 'withoutNew has the correct constructor') |
There was a problem hiding this comment.
It's debatable whether or not these should have constructor == C or constructor == D.
|
I believe I left out the inheritance stuff because it doesn't/didn't work properly with native types e.g. Array/Promise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing test case for #1
It looks like you weren't testing inheritance from the factory, previously. I'm not sure if you meant to support that use case or not, but I think it'd be nice.
Fwiw, I'm trying to use
to-factoryas a decorator beforeexport, as below, so I can use the class as a factory throughout my codebase. I'm sure there are valid arguments against doing this, but I like it well enough for the codebase I'm working on.