Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No output for git name with space #2

Closed
aelam opened this issue Dec 23, 2016 · 8 comments
Closed

No output for git name with space #2

aelam opened this issue Dec 23, 2016 · 8 comments

Comments

@aelam
Copy link

aelam commented Dec 23, 2016

通过 npm install -g weekly-report 安装

切换到含有git仓库的目录, 没有任何输出
切换到git仓库的下面, 没有任何输出

@timqian
Copy link
Owner

timqian commented Dec 23, 2016

What system did you use? This tool has only tested on my mac.
What version of node did use?
How did you run weekly-report?

@aelam
Copy link
Author

aelam commented Dec 23, 2016

running on mac
node version:v5.4.1
cd /path/to/git_repo/parent then run wr no output
cd /path/to/git_repo then run wr no output

@timqian
Copy link
Owner

timqian commented Dec 23, 2016

I tried v5.4.1 on my mac, but it works fine.

I think maybe it is because you don't have commits in the last 7 days :)

If not, can you try to run

DEBUG=* wr

and past the out put here?

@aelam
Copy link
Author

aelam commented Dec 23, 2016

I was thinking if it's the name matter.
now I am sure it's the reason. My git user.name contains a space

  index generate log for:  /Users/jenkins/Desktop/components/mskeyboard +89ms
  oneReport gitLogCommentToRun:  cd /Users/jenkins/Desktop/components/mskeyboard && git log --after 2016-12-16 --author Ryan Wang +90ms

@aelam
Copy link
Author

aelam commented Dec 23, 2016

getOneReports.js

  const gitLogCommentToRun = `cd ${dirname} && git log --after ${dateStr} --author '${name}'`;

@timqian
Copy link
Owner

timqian commented Dec 23, 2016

Cool, I have updated the code according to your comment. Plz install again and try

@aelam
Copy link
Author

aelam commented Dec 23, 2016

How about the ${dirname} . it also could contain space?
const gitLogCommentToRun = cd ${dirname} && git log --after ${dateStr} --author '${name}';

@timqian timqian changed the title 没有任何提示 No output for git name with space Dec 23, 2016
timqian pushed a commit that referenced this issue Dec 23, 2016
@timqian
Copy link
Owner

timqian commented Dec 23, 2016

Yeah, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants