fix(args): add missing configure_notifications argument #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This led to errors when running `python3 main.py code --configure-only -f max-mustermann.json`.
timreibe
changed the title
timreibe
added a commit
that referenced
this pull request
Jun 30, 2021
* - Fix creation of random code (#499) Co-authored-by: Juri <j.robl@osram.com> * feat(uc): Use undetected chromedriver (#497) * Varied sleep time for each call, to make it less predictable and more user-like * Use a random, real useragent * Use a random, real useragent from fake-useragent * Wait some time between clicks * Force some minimum sleeptime for random_sleeps * - Use random_sleep more often - Replace 'VACC-IPYx-xxxx' with complete random code * # Refactored mouse movements # Use computed movements more often # Wiggle a bit after reaching the correct values * # Removed fake-useragent because it was unreliant * # First test for replacing normal chromedriver with undetected-chromedriver * # First test for replacing normal chromedriver with undetected-chromedriver * # Remove selenium-wire requests from selenium_code_anfordern, by @jonas * - Removed mouse movements by @jonasmock - Fixed annotations * - Close driver after successfull code request Co-authored-by: Juri <j.robl@osram.com> * added chromedriver again (#502) * fix(readme): Termineingrenzung Feature in Readme eingefügt. (#508) * feat(local-chromium): replacing chromedriver binaries with google chrome or custom chromium installation (#509) * disabled local chromedriver, replaced with google chrome or custom chromium installation * option 3: set environment variables * returning webdriver exectuable as a string * fix(args): add missing configure_notifications argument (#514) * Update README.md * add missing configure_notifications argument This led to errors when running `python3 main.py code --configure-only -f max-mustermann.json`. Co-authored-by: Julius Jacobitz <47418007+JuliusJacobitz@users.noreply.github.com> Co-authored-by: Genmutant <github@jurirobl.de> Co-authored-by: Juri <j.robl@osram.com> Co-authored-by: Linus Schaub <linusschaub@googlemail.com> Co-authored-by: Christian Jülg <c.juelg+github@gmail.com> Co-authored-by: Julius Jacobitz <47418007+JuliusJacobitz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This led to errors when running
python3 main.py code --configure-only -f max-mustermann.json.