When an error is caught at the command level, log its stack trace #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each of our commands' handlers is wrapped with an error handler, `actionErrorHandler`, which logs the error message in red and then exits with status code `1`. An error's message is not necessarily super helpful - as seen with the `Cannot read properties of null (reading '__typename')` error in #85. This additionally logs the stack trace, giving more context on what went wrong and where.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each of our commands' handlers is wrapped with an error handler,
actionErrorHandler, which logs the error message in red and then exits with status code1.An error's message is not necessarily super helpful - as seen with the
Cannot read properties of null (reading '__typename')error in #85. This additionally logs the stack trace, giving more context on what went wrong and where.