Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with Logitech Litra Beam LX #288

Closed
jbsparrow opened this issue Dec 13, 2023 · 7 comments · Fixed by #294
Closed

Does not work with Logitech Litra Beam LX #288

jbsparrow opened this issue Dec 13, 2023 · 7 comments · Fixed by #294
Labels

Comments

@jbsparrow
Copy link

I see that the code does not have support for the Litra Beam LX. I tried connecting to it by adding it to the driver file but the HID values are incorrect so all readings from it are wrong. I do not have any experience with brute forcing HID codes. Could someone who has experience with bruteforcing HID values help me out?

@timrogers
Copy link
Owner

@jbsparrow 👋 Another Litra device - how exciting! It sounds like this one is totally different to the others, which will introduce some fun challenges.

I didn't actually sniff the HID values originally - frankly, I copied those from other projects and wrote a (in my opinion better 😅 !) wrapper.

It looks like this fork of litra might work with the Beam LX: https://github.com/lnovelli/litra-lx.

Can you test that and see how you get on? If it works, I'd be happy to adapt those changes and bring them into this project, whilst also continuing to support other Litra devices.

@jbsparrow
Copy link
Author

Thank you! I tested it and it works perfect! I'm not sure how the changes affect support for the other litra products and am unable to test it. Hopefully the changes can be merged with no issues.

Your wrapper is definitely better than any of the others I've seen so far :)

@timrogers
Copy link
Owner

@jbsparrow That's great news! I'll take a look at this over the next few days and will add Beam LX support to this package for the basic features - would you be willing to test it once I have some working code? 😊

@jbsparrow
Copy link
Author

I would be glad to test it!

timrogers added a commit that referenced this issue Dec 23, 2023
This pull request adds basic support for the Logitech Litra Beam
LX, a new Litra device from Logitech.

The code is inspired by [@lnovelli](https://github.com/lnovelli/litra-lx)'s
fork of this project, where @lnovelli has already kindly worked
out the new device's details and how it works 💜

For now, this just supports our existing functionality (managing
the device's on/off state, brightness and temperature), and not
the Litra Beam LX's coloured RGB zone.

Fixes #288.
@lnovelli
Copy link

Hi @timrogers and @jbsparrow ! Thank you for creating this extremely helpful wrapper and I'm glad to see that my (quite dirty 😅) fork is helping, I created it in a rush for a Hackathon 🙈 Unfortunately I think that my changes might break compatibility with the standard Litra Beam/Glow as I had to change a couple of HID bytes in almost every function to make it work on the Beam LX. Let me know if that's the case and if I can be of any help! Best

@timrogers
Copy link
Owner

Hi @timrogers and @jbsparrow ! Thank you for creating this extremely helpful wrapper and I'm glad to see that my (quite dirty 😅) fork is helping, I created it in a rush for a Hackathon 🙈 Unfortunately I think that my changes might break compatibility with the standard Litra Beam/Glow as I had to change a couple of HID bytes in almost every function to make it work on the Beam LX. Let me know if that's the case and if I can be of any help! Best

No worries at all - your fork had the all-important research on the HID bytes, and I've written this PR to send the right bytes based on the device ☺️ Thank you for figuring out the hard bits!

timrogers added a commit that referenced this issue Jan 8, 2024
This pull request adds basic support for the Logitech Litra Beam
LX, a new Litra device from Logitech.

The code is inspired by [@lnovelli](https://github.com/lnovelli/litra-lx)'s
fork of this project, where @lnovelli has already kindly worked
out the new device's details and how it works 💜

For now, this just supports our existing functionality (managing
the device's on/off state, brightness and temperature), and not
the Litra Beam LX's coloured RGB zone.

Fixes #288.
Copy link

github-actions bot commented Jan 8, 2024

🎉 This issue has been resolved in version 4.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants