Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

referenced, but not defined codes #5

Open
chrisroederucdenver opened this issue Jan 8, 2023 · 11 comments
Open

referenced, but not defined codes #5

chrisroederucdenver opened this issue Jan 8, 2023 · 11 comments
Assignees
@putmantime @joeflack4

Comments

@chrisroederucdenver
Copy link
Member

chrisroederucdenver commented Jan 8, 2023 •
edited by joeflack4

After fixing the other two bugs in the json file, the data still wouldn't load.
I'm not there yet, but the process runs longer after removing references to concepts that don't exist. The references look like this:

"valueCode": "https://loinc.org/LP33103-0"
"valueCode": "https://loinc.org/LP33117-0"
"valueCode": "https://loinc.org/lc0000001"

back in the merged_reasoned_loinc.owl , the concepts exist in a single line each, that I'm guessing are the definitions.

    <owl:Class rdf:about="https://loinc.org/lc0000001">
   <owl:Class rdf:about="https://loinc.org/LP33117-0">
    <owl:Class rdf:about="https://loinc.org/LP33103-0">

More detail about these guys:

    <owl:Class rdf:about="https://loinc.org/lc0000001">
        <rdfs:subClassOf rdf:resource="http://www.w3.org/2002/07/owl#Thing"/>
    </owl:Class>
    
    <owl:Class rdf:about="https://loinc.org/LP33117-0">
        <rdfs:subClassOf rdf:resource="http://www.w3.org/2002/07/owl#Thing"/>
    </owl:Class>
  
   <owl:Class rdf:about="https://loinc.org/LP33103-0">
        <rdfs:subClassOf rdf:resource="http://www.w3.org/2002/07/owl#Thing"/>
    </owl:Class>
    
## Related
- https://github.com/geneontology/obographs/issues/90
- https://github.com/ontodev/robot/issues/1082
@chrisroederucdenver chrisroederucdenver mentioned this issue Jan 8, 2023
Open
@joeflack4
Copy link
Contributor

Hey @chrisroederucdenver Sorry to see you working late on the weekend on this. I thought @ShahimEssaid was going to load these earlier.

It looks like some of them just don't have labels. I'm not sure why..

Just a couple notes of some things that look to be contradictory. LP33032-1 is in your last snippet, but not in the first two. LP33117-0 is in the first two, but not in the last. So maybe you meant one or the other of these.

@chrisroederucdenver
Copy link
Member Author

chrisroederucdenver commented Jan 8, 2023 •
edited

LP33117-0 owl example fixed.

How does a missing label impact those concepts? Can you show examples with and without to be more clear?

@chrisroederucdenver
Copy link
Member Author

chrisroederucdenver commented Jan 8, 2023 •
edited

As far as testing these files, I've been maintaining jpaserver-scripts to set up a server and load data. It's what I've been using and what I used this evening. You should be able to run them yourself on your mac and test your work.

@joeflack4
Copy link
Contributor

Oh, sorry. I don't see why a missing label would cause an issue, but when you said they were undefined I wasn't sure what you meant. The last snippet you had looked like appropriate class definitions to me.

That sounds good to me, the jpaserver-scripts. I thought Shahim was going to load them / let me know if there was an issue at this point. My plan was just to curl POST them to our live server, at least before the connectathon.

@chrisroederucdenver
Copy link
Member Author

chrisroederucdenver commented Jan 8, 2023 via email

@joeflack4
Copy link
Contributor

Hey Chris. I don't disagree w/ that. I'm really sorry about this. I do have unit tests. They're just not for the server upload. I haven't had a lot of time. I was trying to upload via the UI, but when I told you guys about this, Shahim said he would upload for me. I agree with you this is not good at this stage.

@joeflack4
Copy link
Contributor

joeflack4 commented Jan 8, 2023 •
edited

Also, btw now that I think about it, it could be because the work is not actually finished yet. It's been a lot slower since OAK. But there are still some easy things to do. I think it's just missing some required top level properties from CodeSystem, like status and content.

@chrisroederucdenver
Copy link
Member Author

chrisroederucdenver commented Jan 8, 2023 via email •
edited

@chrisroederucdenver
Copy link
Member Author

OAK is slower. I've used breaks like that to work on other things, like the TimsUI. When its crunch time, you have to be creative.

TRIM YOUR TEST INPUT DOWN TO SIZE.

When you get the small, like 1/100th size, one working, build a larger file and find out what bugs were lurking there. rinse. repeat.

If you haven't, have a look at the unix tools head and tail. I did this sort of thing to narrow down the json when looking for that bug with the missing references.
` unix> head -1000 file.owl > file_short.owl
Then go into Vi (or other editor) to clean up the last map and list with } and ].

@joeflack4
Copy link
Contributor

Thanks Chris. This is all stuff I'm familiar with. By OAK being slower, I don't mean the conversion process, I mean the development process.

@joeflack4 joeflack4 mentioned this issue Jan 9, 2023
Open
1 task
@joeflack4
Copy link
Contributor

joeflack4 commented Jan 9, 2023 •
edited

I looked and this seems to be an Obographs issue: ontodev/robot#1082 / geneontology/obographs#90

I'll put in a workaround for this for now.

@joeflack4 joeflack4 mentioned this issue Jan 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@putmantime putmantime

@joeflack4 joeflack4

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@putmantime @joeflack4 @chrisroederucdenver