Skip to content
This repository has been archived by the owner on Nov 21, 2021. It is now read-only.

Compact find bar overlaps sidebar when moved to right #44

Closed
Keith94 opened this issue Sep 24, 2017 · 7 comments
Closed

Compact find bar overlaps sidebar when moved to right #44

Keith94 opened this issue Sep 24, 2017 · 7 comments

Comments

@Keith94
Copy link

Keith94 commented Sep 24, 2017

Regarding the style: compact-findbar-on-top.css

image

@Madis0
Copy link
Collaborator

Madis0 commented Sep 29, 2017

That is a bit hard to fix, since the position is fixed and even if I somehow set a second position for when sidebar is opened, you can adjust sidebar's width too, making it still "break".

As a workaround, I would suggest setting right: 1em; to a value you prefer, such as 19em.

@Timvde
Copy link
Owner

Timvde commented Sep 30, 2017

Alternatively, would left: 1em move it to the top left?

@Madis0
Copy link
Collaborator

Madis0 commented Sep 30, 2017

In that case, one can remove that line entirely (default is left with zero margin).

@Timvde
Copy link
Owner

Timvde commented Oct 9, 2017

I suppose that there is no way to check in CSS whether the sidebar is open, and on which side it is?

@Madis0
Copy link
Collaborator

Madis0 commented Oct 9, 2017

I guess it might be, but I don't have the time/tools to find out at the moment.

@Madis0
Copy link
Collaborator

Madis0 commented Oct 28, 2017

I have now found out that there is a parameter called ordinal that says whether the sidebar is on the left or right, so as an example one could do this:

#sidebar-box[ordinal="2"]{ /* red if left */
  background-color: red !important;
}

#sidebar-box[ordinal="4"]{ /* green if right */
  background-color: green !important;
}

Only question is, how to use that to adjust the find bar? Something like

#sidebar-box[ordinal="4"] > .browserContainer > findbar {
  left: 0em !important;
}

didn't do the trick.

@Timvde
Copy link
Owner

Timvde commented Dec 27, 2017

I think some magic with the :has selector could do the trick: https://developer.mozilla.org/en-US/docs/Web/CSS/:has

But that compatibility table looks kinda depressing :P I don't think this is currently possible.

@Keith94 Keith94 closed this as completed Jun 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants