New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly check for truthiness of `generated_by` #124

Merged

timvink merged 2 commits into timvink:master from oprypin:patch-2

Nov 11, 2023

Contributor

oprypin commented Nov 10, 2023

This change will actually make the current check wrong:
Add generated_by attribute to File class mkdocs/mkdocs#3344

oprypin added 2 commits

November 10, 2023 20:00


          Correctly check for truthiness of generated_by

c2d432b


          Make the check actually safe

c255498

Owner

timvink commented Nov 11, 2023

Thanks!

timvink merged commit d528007 into timvink:master

15 checks passed

oprypin deleted the patch-2 branch

November 11, 2023 10:23

Contributor Author

oprypin commented Dec 15, 2023

Could you make a release with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment