Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2.3 breaks integration with Material for MkDocs #127

Closed
squidfunk opened this issue Feb 3, 2024 · 5 comments
Closed

1.2.3 breaks integration with Material for MkDocs #127

squidfunk opened this issue Feb 3, 2024 · 5 comments

Comments

@squidfunk
Copy link
Sponsor Collaborator

Sadly, the latest release breaks the integration with Material for MkDocs. I'm not sure what we need to do here other than to tell our users to downgrade to 1.2.2, because until now, it is completely unclear how a migration path should look. I might be missing something, but the maintainers of MkDocs have yet not provided instructions how to make themes and plugins downward compatible. It is the exact reason I'm raising awareness

Downstream issue: squidfunk/mkdocs-material#6734

@timvink
Copy link
Owner

timvink commented Feb 3, 2024

Thanks for letting me know. Will revert and make a new release soon

@oprypin
Copy link
Contributor

oprypin commented Feb 3, 2024

@timvink Sorry about the bad change, this was supposed to be about forwards compatibility but instead made a separate breakage. Could I try to make the change again but correctly this time 🥺
#126 (comment)

@timvink
Copy link
Owner

timvink commented Feb 3, 2024

No worries, it's on me, I should have tested more.

Let's try again 👍

@timvink
Copy link
Owner

timvink commented Feb 3, 2024

It's released

@timvink timvink closed this as completed Feb 3, 2024
@oprypin
Copy link
Contributor

oprypin commented Feb 3, 2024

Let's try again 👍

Thank you. The reland is ready for your consideration
#128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants