Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing _vars deprecation warning #132

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Conversation

dbermuehler
Copy link
Contributor

With the latest mkdocs version (1.6.0), I received this deprecation warning when calling mkdocs serve or mkdocs build:

INFO    -  DeprecationWarning: Do not access Theme._vars, instead access the keys of Theme directly.
             File "/Users/dbermuehler/.local/share/virtualenvs/test-sX96YhBS/lib/python3.11/site-packages/mkdocs_git_revision_date_localized_plugin/plugin.py", line 82, in on_config
               theme_locale = custom_theme._vars.get("locale")
             File "/Users/dbermuehler/.local/share/virtualenvs/test-sX96YhBS/lib/python3.11/site-packages/mkdocs/theme.py", line 87, in _vars
               warnings.warn(

This PR will fixes this.

@timvink
Copy link
Owner

timvink commented Apr 26, 2024

Thanks!

@timvink timvink merged commit 530e842 into timvink:master Apr 26, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants