Builds without OpenSSL

[vks]

It would be nice to have to build ffsend using ring instead of OpenSSL. This would likely simplify the build on Windows and use a more minimal crypto library.

As far as I can see, this requires the following changes:

• Make reqwest use rustls:

diff --git a/Cargo.toml b/Cargo.toml
index ad5df53..f6259c1 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -48,7 +48,7 @@ mime = "0.3.12" # same as reqwest
 mime_guess = "2.0.0-alpha.4"
 openssl = "0.10"
 regex = "1.1"
-reqwest = "0.9.2"
+reqwest = { version = "0.9.2", features = ["rustls"] }
 serde = "1.0"
 serde_derive = "1.0"
 serde_json = "1.0"

• Port random data generation to ring.
• Port signing to ring.
• Port encryption to ring.

The last part is likely the most tedious.

[timvisee]

I've tried this before but canceled it because it was too much work.

I'm in for it though, implementing this would be awesome! I think the requirements you mentioned are spot on. The crypto logic is currently isolated quite well in the src/crypto directory.

Currently I want to focus on other things first, and might start with this at a later time. Working on a ring branch along with master to slowly implement ringsupport would probably be a good idea. I'd like to emphasize that I would prefer supporting both crypto backends, togglable using a compiler feature flag.

If there's someone else that wants to start with this, go for it!

[timvisee]

I've created the following issue for this: https://gitlab.com/timvisee/ffsend-api/issues/6

Work will be made in the crypto-ring branch.

[vks]

Thanks for the follow up! I ported some parts to ring on my branch, you might want to use that:

• Symmetric encryption: vks@a39296c
• Signing: vks@d9da694

[timvisee]

Awesome, thanks for your changes! This looks perfect.

I would like to note that the primary repository is on GitLab infact, this repository on GIthub is just a mirror (the crypto-ring branch is only on GitLab). I'll probably merge your changes over there.

I'll be sure to take a look into this later this day after work.

[timvisee]

I've implemented your changes in crypto-ring with conditional compilation (to support both back-ends).

Now, what's left is some cryptography using openssl in src/pipe/crypto/:

[timvisee]

This has now been implemented. Ring is now used as default crypto backend.

This is released as part of v0.6.0.

See the issue over on GitLab for more details: https://gitlab.com/timvisee/ffsend-api/-/issues/6