Minor cleanup #129
Merged
Minor cleanup #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current file was missing the "How to Apply These Terms to Your New Programs" section, which is an integral part of the GPL and is not supposed to be removed: https://www.gnu.org/licenses/gpl-faq.html#GPLOmitPreamble Correct file was downloaded from: https://www.gnu.org/licenses/gpl-3.0.txt
|
Thanks! I'll review and merge tomorrow. |
|
Absolutely no rush :) Thank you for the review and for making ffsend. |
timvisee
requested changes
Aug 26, 2021
There was a problem hiding this comment.
- The double space at the end of lines in Markdown files are intentional to insert a line break.
- The name
reqwestis intentional as it's the name of the backing library.
Other than that, all your changes are great!
I've marked each of the instances with a comment as per above. Would you mind to revert these cases? I'd be happy to merge after.
Edit: this spawned a lot of comments, oops.
|
Thanks for your work! Two things were intentional however, please see the review above. |
|
Thanks for catching that in the review, I addressed all of it and rebased. |
timvisee
approved these changes
Aug 26, 2021
|
Thanks again! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.