Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase password length limit to support passphrases #147

Merged
merged 1 commit into from Feb 14, 2023
Merged

Increase password length limit to support passphrases #147

merged 1 commit into from Feb 14, 2023

Conversation

tdulcet
Copy link

@tdulcet tdulcet commented Feb 13, 2023

I noticed this limitation while testing tdulcet/Thunderbird-Send#8. My add-on could upload files with longer passwords, but the web UI would then not allow users to download the files. 😨 If I used the browser devtools to remove the maxlength attribute, it would work as expected, so there does not seem to be a technical reason for this limitation. I would also be happy to completely remove the password length limit, if that would be OK with you.

This change should also allow you to revert timvisee/ffsend@fdf8ae9.

@timvisee
Copy link
Owner

timvisee commented Feb 14, 2023

Thanks!

so there does not seem to be a technical reason for this limitation

I believe I looked into this before, but I don't recall the reasoning behind this.

I would also be happy to completely remove the password length limit, if that would be OK with you.

What about setting it to 4096? I don't have good reasoning for that though, other than having seen that limit in other places for an "almost infinite length".

@timvisee timvisee added the enhancement New feature or request label Feb 14, 2023
app/ui/archiveTile.js Outdated Show resolved Hide resolved
@timvisee
Copy link
Owner

Thanks!

@timvisee timvisee merged commit dee6b3e into timvisee:master Feb 14, 2023
@tdulcet tdulcet deleted the passphrase branch February 14, 2023 12:44
@timvisee
Copy link
Owner

timvisee commented Feb 14, 2023

This has been released as v3.4.23.

The send.vis.ee host has been updated as well: https://send.vis.ee/__version__

timvisee added a commit to timvisee/ffsend that referenced this pull request Feb 14, 2023
…rs long"

This reverts commit fdf8ae9.

This is reverted because the password length limit is now set much
higher, see: timvisee/send#147
@tdulcet
Copy link
Author

tdulcet commented Feb 14, 2023

Thanks for the quick turnaround!

I am now going to add support for generating passphrases to the next version of my add-on using the long EFF wordlist. They suggest using 6 words and each word is up to 9 letters, so that requires up to (6 * 9) + (6 - 1) = 59 characters. This 4,096 character limit should now more than cover even the most secure passphrases. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove password length limit
2 participants