Force upgrade NPM everything #196
Conversation
|
Happy to test this locally—just to flag, though, that #203 is close enough that I'll be able to remove the built-in admin/editing UI soon, which will remove like 90% of the JavaScript. Not that there are many dependencies, to be fair. I'm at a wedding at the moment, so it might be a few days before I can review—from the looks of it, it's just the build tools, so I'd say if it builds successfully for you, feel free to merge so you're not blocked. |
We will be able to remove many components when removing the frontend editing components, but without these changes I couldn't get webpack to build - which means properly testing it was hard.
|
It can wait - I had to do this to look at removing any parts of the old UI editing bits. But your mileage might be better. Enjoy the weeding! |
BryanQuigley
force-pushed
the
upgrade
branch
from
b9bb717
to
d34652d
Compare
package.json
Outdated
| @@ -7,7 +7,7 @@ | |||
| "test": "echo \"Error: no test specified\" && exit 1", | |||
| "start": "webpack-dev-server --progress --colors", | |||
| "watch": "NODE_ENV=development webpack -d -w", | |||
There was a problem hiding this comment.
I get an error when I run this line, about the devtool syntax being invalid. Looks like that's because -d no longer stands for development in webpack 5, but instead stands for devtool. The way I got it to work was to change this line to:
webpack --mode=development --watchNote that setting it to development mode also sets NODE_ENV to development (source).
Gosh, once we remove the bulk of the JS, let's consider moving to one of the simpler alternatives to webpack!
Also remove unused start script
We will be able to remove many components when removing the frontend editing components, but without these changes I couldn't get webpack to build - which means properly testing it was hard.