Version 2.0 #245
Version 2.0 #245
Conversation
This was necessary to support editing in Netlify CMS. See #207. I've added a line in index.html that should provide backwards compatibility. Note that this commit breaks editing. This could be fixed as well, but since it's being removed as part of the Netlify CMS milestone, I haven't included it here.
license, category, maintainer, maintainer_email
…nd always show them Closes #208
Without this, netlify assumes this is a Node.js application. I think if we add jekyll to Gemfile, Netlify would auto-detect properly, and we wouldn't need this file. But I don't want the jekyll version to get out of sync with the github-pages gem, so let's stick with this for now.
This should be unnecessary now that we explicitly declare jekyll as a dependency in Gemfile
Troubleshooting netlify build
This no longer makes sense as a default setting when the recommended hosting platform is Netlify. It may also be the case that GitHub Pages now automatically adds this setting anyway, which I will test.
Previously, the JavaScript expected baseurl to have a value - at least an empty string. But baseurl should be able to be omitted completely, per https://ben.balter.com/jekyll-style-guide/config/#baseurl
`GITHUB_CLIENT_ID` and `GATEKEEPER_HOST` are no longer in use
This is only necessary when using the git-gateway backend for Netlify CMS. Since we're recommending using the GitHub (OAuth) backend, I think we should remove it by default.
…thub-metadata gem
|
Hi Tim! Thanks for all your work on JKAN! Azavea just joined https://element84.com/ so things are changing a bit here. I just asked if we can do some UI review. I'm not sure we need to sync v2 back to gh-pages. They can stand on their own branches and we can just make v2 the default. This is especially true because the gh-pages branch name is just a hold over from the old way to deploy. The release notes look good to me. @lydiascarf is working on some local development instructions to add as well (the docker ones I wrote early are broken). We also plan to be getting an OpenDataPhilly test site up soon. |
- repository added to config - moved from Jekyll image to Dockerfile based on Ruby image
✅ Deploy Preview for jkan-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Also remove unneeded lines from docker-compose. Related: #254
- Items that have been replaced - New items included
|
@BryanQuigley Interesting point about not merging the branches... Although, would there be much benefit in leaving v1 around as an active branch? I don't think we want to support it, so if it's just for posterity, perhaps a tag in the git history could suffice? 🤔 Also, I'd love if we could name the default branch |
|
Good point, just a git tag is enough - and I do agree main name is nicer... We had to break our fork connection (or else PRs against ODP would try to be against JKAN by default) so the naming doesn't really matter for ODP. Currently working on a plan for how to keep better synced with JKAN (current plan is just rebasing regularly). |
Dropped jekyll-npm mentioning and fixing up container workflow. Also added newer version of node/npm from suggestion. Drop hadolint check as well.
Fixes include: - Jumbotron - List Groups
badge-pill -> rounded-pill badge-* -> bg-* float-right -> float-end
Bootstrap v5 removed background from breadcrumbs by default
…strap-v5 Upgrade to bootstrap v5
* Drop old Add-categories linl * UI: Sidebar: Increase spacing between Categories and Organizations * The original suggestion was Change count pill for selected category and X button to white background with Tim's suggestion moved to bg-light text-dark. Also changed in datasets.html to use primary blue. * UI: Results: Increase spacing to make list more legible. I just added top spacing to datasets to the separator is more in the middle.
Fixes and adds hover effect to categories grid, changes button copy
Homepage tweaks
I've just created a new repository to test this out. I forked it from another user account, then changed the name of the default branch in the upstream repository. I went back to my fork, as the other user, and GitHub was clever enough to flag it to me!
Even better, the "Sync fork" button still works, despite the upstream and downstream repos having two different branch names. Well done, GitHub! I'll just update the release notes and merge this into |
As I was writing the upgrade guide for #244 I started jotting down the release notes, and thought I'd post them in a draft PR since we're close to being able to release anyway. Here's what I have so far. Let me know if I've missed anything.
Breaking changes
3.1.2, and upgrade ruby and JavaScript dependencies to recent versionslicenses.ymlfor compatibility with Decap CMS. As a result,site.data.licensesis nowsite.data.licenses.items.site.data.categoriesis nowsite.dataset_categories.baseurlsetting from_config.ymlNon-breaking changes
/categories/index page and a page per categoryDeprecations
Contributors