Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop IE11 support and remove unmaintained depends #277

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Drop IE11 support and remove unmaintained depends #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions _includes/footer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<!-- general behavior -->
<script type="module" src="{{ site.baseurl }}/scripts/dist/modern/index.js"></script>
<script nomodule src="{{ site.baseurl }}/scripts/dist/legacy/index.js"></script>
<script type="module" src="{{ site.baseurl }}/scripts/dist/index.js"></script>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package.json still uses a named target. I would assume that npm run build still outputs the compiled index.js file to the modern directory, doesn't it? If not, feel free to disregard.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, it doesn't - and this was odd to me as well.


<footer></footer>
11 changes: 0 additions & 11 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 0 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,6 @@
"engines": {
"browsers": "defaults"
}
},
"legacy": {
"engines": {
"browsers": "ie 11"
}
}
},
"license": "MIT",
Expand All @@ -31,7 +26,6 @@
"dependencies": {
"bootstrap": "^5.0.2",
"jquery": "^3.4.1",
"jquery-deparam": "^0.5.3",
"lodash": "^4.17.11"
}
}
53 changes: 26 additions & 27 deletions scripts/dist/modern/index.js → scripts/dist/index.js
View file
Open in desktop

Large diffs are not rendered by default.

53 changes: 0 additions & 53 deletions scripts/dist/legacy/index.js
View file
Open in desktop

This file was deleted.

7 changes: 5 additions & 2 deletions scripts/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
/* global settings */
import 'core-js/actual'
import $ from 'jquery'
import 'jquery-deparam'
import 'bootstrap/js/dist/collapse'

import DatasetsList from './components/datasets-list'
Expand All @@ -10,7 +9,11 @@ import OrganizationsFilter from './components/organizations-filter'
import DatasetDisplay from './components/dataset-display'
import {queryByComponent} from './util'

const params = $.deparam(window.location.search.substr(1))
const urlSearchParams = new URLSearchParams(window.location.search)
const params = {}
urlSearchParams.forEach((value, key) => {
params[key] = value
})

// Helper function to ensure datasets.json is only fetched once per page
let datasetsCache
Expand Down