Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄🔨 Fixed Sizing on Safari #1839

Merged
merged 1 commit into from
Jun 10, 2024
Merged

💄🔨 Fixed Sizing on Safari #1839

merged 1 commit into from
Jun 10, 2024

Conversation

joshbermanssw
Copy link
Contributor

@joshbermanssw joshbermanssw commented Jun 10, 2024

Email thread: ‼️Urgent - Tina.io Homepage - Safari issue

cc: @levijacksonssw

Tailwind gap rendering was behaving differently on safari, causing for the landing page containers to be overlapping - this pr addresses this issue by;

  • Enforcing a margin right between on the left container
  • Reducing the command button size
  • And reducing the size of the left container
Screenshot 2024-06-10 at 7 45 11 pm

Figure: ❌ Overlapping image on safari

Screenshot 2024-06-10 at 7 46 26 pm

Figure: ✅ Safari view (from this PR) with fixed spacing

Note that this does make the google chrome sizing (which was test passed) slightly different

@joshbermanssw joshbermanssw requested a review from a team as a code owner June 10, 2024 09:47
Copy link

vercel bot commented Jun 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tina-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2024 9:56am

@joshbermanssw joshbermanssw changed the title Fixed Sizing on Safari 💄🔨 Fixed Sizing on Safari Jun 10, 2024
@joshbermanssw joshbermanssw merged commit d7500f6 into main Jun 10, 2024
4 checks passed
@joshbermanssw joshbermanssw deleted the fix-Safari-render branch June 10, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants