🐛 Nav Bar Flicker Bug #1847
Merged
🐛 Nav Bar Flicker Bug #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bradystroud
approved these changes
Jun 12, 2024
bradystroud
added a commit
that referenced
this pull request
Jun 13, 2024
This reverts commit 7103692.
bradystroud
added a commit
that referenced
this pull request
Jun 13, 2024
This was referenced Jun 13, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @bradystroud
As per email from @adamcogan
(Checked by Marcus, Eve)
Heya Josh 👋
https://youtu.be/Vagxix6k3ik?si=EdRsEkVCE1vU_vm2
Why at 14:29 does it flicker?
Can you fix?
This PR addresses this issue, re-working how the nav bar fixed mode is set. This was the issue causing the flickering behaviour