Skip to content

Commit

Permalink
fix: Docs & Nuke.sh
Browse files Browse the repository at this point in the history
Used Jeff's PR to find an additional place in the docs that needed to be updated and confirmed with DJ that the `--` should actually immediately follow `npm run lerna` (something he discovered when trying to do a release).

Updated `nuke`, as well.
  • Loading branch information
Enigmatical committed Mar 30, 2021
1 parent 4e743ac commit da36b61
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
Expand Up @@ -39,7 +39,7 @@ TinaCMS uses [Lerna](https://lerna.js.org/) to manage dependencies when developi
| npm run bootstrap | Install dependencies and link local packages. |
| npm run build | Build all packages. |
| npm run test | Run tests for all packages. |
| npm run lerna run build -- --scope \<package> | Build only \<package>. |
| npm run lerna -- run build --scope \<package> | Build only \<package>. |

### Testing With External Projects

Expand Down Expand Up @@ -97,7 +97,7 @@ Linking prevents running `npm install` from directly inside a package from worki
You can use lerna to add new dependencies to a package from the root of the repository:

```
npm run lerna add react --scope react-cms
npm run lerna -- add react --scope react-cms
```

The downside of this approach is you can only add one dependency at a time. If you need to add many packages, you can use the next method.
Expand All @@ -108,7 +108,7 @@ Linking prevents running `npm install` from directly inside a package from worki

3. **When I run `npm run bs` it deletes the contents of a package?**

This sucks. Try running `npm run lerna clean` and then running `npm run bs` again.
This sucks. Try running `npm run lerna -- clean` and then running `npm run bs` again.

### Failed to Compile: Module not found: Can't resolve 'some-tinacms-package'

Expand Down
2 changes: 1 addition & 1 deletion scripts/nuke.sh
@@ -1,7 +1,7 @@
#!/bin/bash

# Deletes all node_modules
npm run lerna clean -y
npm run lerna -- clean -y

# rm -rf node_modules

Expand Down

0 comments on commit da36b61

Please sign in to comment.