Feat/media store s3

[Phoenix-Alpha]

No description provided.

[changeset-bot]

🦋 Changeset detected

Latest commit: 9333ec6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
next-tinacms-s3	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

Modified Packages

The following packages were modified by this pull request:

• next-tinacms-s3

Generated by 🚫 dangerJS against 9333ec6

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
tinacms-monorepo	❌ Failed (Inspect)		Aug 26, 2022 at 3:59PM (UTC)

[jeffsee55]

I ran into a couple issues getting this running:

• First the build wasn't able to find @aws-sdk/signature-v4-crt, it looks like that's a peer dep on @aws-sdk/signature-v4-multi-region.
• After adding that as a dependency I ran into this error:

  warn  - ../../node_modules/.pnpm/aws-crt@1.14.1/node_modules/aws-crt/dist/native/binding.js
  Critical dependency: the request of a dependency is an expression
  (node:66552) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
  

[Phoenix-Alpha]

@jeffsee55, Can you send me the full error log?

[Phoenix-Alpha]

@jeffsee55 ,
Do you still have the issue with running?

[jeffsee55]

@Phoenix-Alpha yes I'm still seeing this issue, here's the full log:

warn  - ../../node_modules/.pnpm/@aws-sdk+signature-v4-multi-region@3.130.0/node_modules/@aws-sdk/signature-v4-multi-region/dist-cjs/SignatureV4MultiRegion.js
Module not found: Can't resolve '@aws-sdk/signature-v4-crt' in '/Users/jeffsee/code/tinacms2/node_modules/.pnpm/@aws-sdk+signature-v4-multi-region@3.130.0/node_modules/@aws-sdk/signature-v4-multi-region/dist-cjs'

../../node_modules/.pnpm/@aws-sdk+util-user-agent-node@3.127.0/node_modules/@aws-sdk/util-user-agent-node/dist-cjs/is-crt-available.js
Module not found: Can't resolve 'aws-crt' in '/Users/jeffsee/code/tinacms2/node_modules/.pnpm/@aws-sdk+util-user-agent-node@3.127.0/node_modules/@aws-sdk/util-user-agent-node/dist-cjs'
(node:59076) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
(Use `node --trace-deprecation ...` to show where the warning was created)

[jeffsee55]

This is happening from within the monorepo, here's my branch: https://github.com/tinacms/tinacms/compare/test-media-store-s3?expand=1

[Phoenix-Alpha]

I got the same error but not sure what is the reason.

Actually, I tested using tina-cloud-tester not using experimental example.

[Phoenix-Alpha]

Could you test on tina-cloud-starter using this pack? @jeffsee55
tina-cloud-starter.zip

[jeffsee55]

We'll need this to work for pnpm as well as yarn (which is what the starter uses). I expect we need to add a dependency that's missing from an S3 library.

[Phoenix-Alpha]

Could you push your code used to test DO Space integration? @jeffsee55

[Phoenix-Alpha]

@jeffsee55 , I think we can test the s3 integration locally with tina-cloud-starter(the independent repository).
Reference: https://dev.to/scooperdev/use-npm-pack-to-test-your-packages-locally-486e

[jeffsee55]

Could you push your code used to test DO Space integration? @jeffsee55

I used the monorepo for this and it worked fine.

I got the same error but not sure what is the reason.

I think this is a blocker for this feature. I'm sure it works fine in some contexts but my concern isn't about being able to test it with different environments. The issue is that there's a breakdown in the dependency chain that we need to resolve so users who are using PNPM or Yarn (with Pnp) which are much more strict don't run into issues.

[Phoenix-Alpha]

@jeffsee55 , I added @aws-sdk/signature-v4-crt as a devDependency and it worked. Plz check https://github.com/tinacms/tinacms/compare/feat/media-store-s3...test-media-store-s3?expand=1

[jeffsee55]

devDependency and it worked

I think this will need to be a dependency. It might work in the monorepo because devDependencies are present, but those wouldn't get installed, whereas dependencies would.

[Phoenix-Alpha]

@jeffsee55 I changed it to a dependency from devDependency and it still works well. Please confirm.

[jeffsee55]

@Phoenix-Alpha did you push those changes to this branch?

[Phoenix-Alpha]

@Phoenix-Alpha did you push those changes to this branch?

@jeffsee55, I pushed to this branch - https://github.com/tinacms/tinacms/tree/test-media-store-s3

[jeffsee55]

This is working for me now, thanks @Phoenix-Alpha! I've updated on this branch so will just merge in once CI passes