Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing branch ux #3992

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Missing branch ux #3992

merged 2 commits into from
Jun 6, 2023

Conversation

jamespohalloran
Copy link
Contributor

@jamespohalloran jamespohalloran commented Jun 6, 2023

Update UI for branch not existing

Changes:

  • Show branch modal regardless of your page
  • Tweak messaging to make it seem less "error'ey"
  • Don't allow user to dismiss modal
Screen Shot 2023-06-06 at 12 54 37 PM

@jamespohalloran jamespohalloran requested a review from a team as a code owner June 6, 2023 16:06
@changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2023

⚠️ No Changeset found

Latest commit: b4769a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jamespohalloran jamespohalloran merged commit 0ea106f into new-branch-model Jun 6, 2023
7 checks passed
@jamespohalloran jamespohalloran deleted the missing-branch-ux branch June 6, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants