refactor(sidebar state): moved onto TinaCMS #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change reifies the sidebar state and places
it on the TinaCMS class as a property. It also
removes the need for the `SidebarContext`
in the React app, instead relying on the
pre-existinig CMSContext.
Here is how it would be used.
Checking sidebar state:
cms.sidebar.isOpen
Changing sidebar state:
cms.sidebar.isOpen = true
Subscribing Option 1
import { useCMS, useSubscribable } from "tinacms"
const cms = useCMS()
useSubscribable(cms.sidebar)
Subscribing Option 2:
const sidebar = useSidebar()
ncphillips
requested review from
spbyrne,
weibenfalk,
dwalkr and
kendallstrautman
Modified PackagesThe following packages were modified by this pull request:
|
kendallstrautman
approved these changes
Jan 21, 2020
|
I think it's great to remove the SidebarContext when it's not needed. One question .. how can you use "private" in the JS Class? Thought private wasn't supported. =) Isn't a private field still experimental and it uses # instead? |
|
It's a Typescript feature. The ECMAscript private fields syntax is coming in 3.8, but we're not on that yet. |
|
ahhh ok ... that explains things. Great, thanks for the info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking for everyone's thoughts on this.
I started mulling over the Sidebar state after checking out @weibenfalk's thoughts on configuring the text on the Save/Reset buttons.
This change reifies the sidebar state and places it on the TinaCMS class as a property. I think this approach has a couple benefits:
SidebarContextin the React app, instead relying on the pre-existinig CMSContext.Here is how it would be used.
Checking sidebar state:
Changing sidebar state:
Subscribing Option 1
Subscribing Option 2: