Fix client parse errors with '=' in remark strings #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace every '=' with '-' in the remark string to avoid parse errors from the clients.
|
Tested by myself, build with Github Actions, run with macOS 14.0. BEFORE: (surge parse error due to illegal '=' in remark strings.) AFTER (fixed by this pr): |
nftbty
pushed a commit
to nftbty/subconverter
that referenced
this pull request
Oct 10, 2023
Replace every '=' with '-' in the remark string to avoid parse errors from the clients.
kadaliao
pushed a commit
to kadaliao/subconverter
that referenced
this pull request
Oct 16, 2023
Replace every '=' with '-' in the remark string to avoid parse errors from the clients.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace every '=' with '-' in the remark string to avoid parse errors from the clients.
当节点名称中含有'='时，输出的conf文件可能无法被代理软件（如surge）正确解析，因此需要替换节点名称中的'='为'-'.