fix(Tinebase/Calendar): determine window title of edit dialog based o…

…n id
tine-groupware · Mar 19, 2024 · d8e40df · d8e40df
1 parent de86986
commit d8e40df
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/tine20/Calendar/js/EventEditDialog.js b/tine20/Calendar/js/EventEditDialog.js
@@ -700,6 +700,10 @@ Tine.Calendar.EventEditDialog = Ext.extend(Tine.widgets.dialog.EditDialog, {
         Tine.Calendar.EventEditDialog.superclass.onRecordLoad.call(this);
     },
 
+    isNewRecord: function () {
+        return !this.record || !(this.record.get && this.record.get('creation_time'))
+    },
+
     /**
      * is called after all subpanels have been loaded
      */

diff --git a/tine20/Tinebase/js/widgets/dialog/EditDialog.js b/tine20/Tinebase/js/widgets/dialog/EditDialog.js
@@ -1047,7 +1047,7 @@ Tine.widgets.dialog.EditDialog = Ext.extend(Ext.FormPanel, {
             this.doCopyRecord();
             this.window.setTitle(String.format(i18n._('Copy {0}'), this.i18nRecordName));
         } else {
-            if (!this.record || !(this.record.get && this.record.get('creation_time'))) {
+            if (this.isNewRecord()) {
                 this.window.setTitle(formatMessage('{gender, select, male {Add New {recordName}} female {Add New {recordName}} other {Add New {recordName}}}', {
                     gender: this.recordClass.getRecordGender(),
                     recordName: this.i18nRecordName
@@ -1076,6 +1076,14 @@ Tine.widgets.dialog.EditDialog = Ext.extend(Ext.FormPanel, {
         wrapTicket();
     },
 
+    /**
+     * overwrite if record id is already set on new records
+     * @returns {boolean}
+     */
+    isNewRecord: function () {
+        return !this.record || !(this.record.get && this.record.id )
+    },
+
     setReadOnly: function(readOnly) {
         this.readOnly = true;
         this.action_saveAndClose.setHidden(readOnly);